Elysian Shadows

Ginto8 wrote:Nah, the issue is that more than one object provides a definition for certain functions, creating weird issues. You can probably solve this by putting "inline" in front of global function declarations that are defined in the header.

Aleios wrote:It says that "bool quit" is already defined in AI.obj, which basically means that this globals.h is being included in multiple files, thus its trying to define an already defined global variable. And its first come first serve.

/***
*new.cxx - defines C++ new routine
*
*       Copyright (c) Microsoft Corporation.  All rights reserved.
*
*Purpose:
*       Defines C++ new routine.
*
*******************************************************************************/


#ifdef _SYSCRT
#include <cruntime.h>
#include <crtdbg.h>
#include <malloc.h>
#include <new.h>
#include <stdlib.h>
#include <winheap.h>
#include <rtcsup.h>
#include <internal.h>

void * operator new( size_t cb )
{
    void *res;

    for (;;) {

        //  allocate memory block
        res = _heap_alloc(cb);

        //  if successful allocation, return pointer to memory

        if (res)
            break;

        //  call installed new handler
        if (!_callnewh(cb))
            break;

        //  new handler was successful -- try to allocate again
    }

    RTCCALLBACK(_RTC_Allocate_hook, (res, cb, 0));

    return res;
}
#else  /* _SYSCRT */

#include <cstdlib>
#include <new>

_C_LIB_DECL
int __cdecl _callnewh(size_t size) _THROW1(_STD bad_alloc);
_END_C_LIB_DECL

void *__CRTDECL operator new(size_t size) _THROW1(_STD bad_alloc)
        {       // try to allocate size bytes
        void *p;
        while ((p = malloc(size)) == 0)
                if (_callnewh(size) == 0)
                {       // report no memory
                static const std::bad_alloc nomem;
                _RAISE(nomem);
                }

        return (p);
        }

/*
 * Copyright (c) 1992-2002 by P.J. Plauger.  ALL RIGHTS RESERVED.
 * Consult your license regarding permissions and restrictions.
 V3.13:0009 */
#endif  /* _SYSCRT */

[Frames below may be incorrect and/or missing, no symbols loaded for SDL.dll]

 while ((p = malloc(size)) == 0)
                if (_callnewh(size) == 0)
                {       // report no memory
                static const std::bad_alloc nomem;
                _RAISE(nomem);
                }

qpHalcy0n wrote:Trade contact info with me and I'll resolve the problem with you.

MrDeathNote wrote:

Aleios wrote:It says that "bool quit" is already defined in AI.obj, which basically means that this globals.h is being included in multiple files, thus its trying to define an already defined global variable. And its first come first serve.

It's not because it's included in multiple files. That wouldn't make any difference since there are #ifndef guards around the header. What use would it be if you couldn't include it in multiple files.

bool quit;

int main()
{
return 0;
}

bool quit;

#include "booltest.h"

int main()
{
return 0;
}

#include "booltest.h"

//Nothing here

#ifndef BOOLTEST_H
#define BOOLTEST_H

bool quit;

#endif

Aleios wrote: For reference:

main.cpp

Code: Select all

bool quit;

int main()
{
return 0;
}

booltest.cpp

Code: Select all

bool quit;

ISSUE, Definition of same name and type

Aleios wrote: this is also an issue:

main.cpp

Code: Select all

#include "booltest.h"

int main()
{
return 0;
}

booltest.cpp

Code: Select all

#include "booltest.h"

//Nothing here

booltest.h

Code: Select all

#ifndef BOOLTEST_H
#define BOOLTEST_H

bool quit;

#endif

ISSUE: this will still redefine the global

MrDeathNote wrote: This is an issue, and it was my original thought but I assumed (perhaps incorrectly) that since he's gotten this far he could spot a simple variable redefinition.

MrDeathNote wrote: Emmm this wouldn't cause a problem unless main included booltest.cpp which I hope you would never do.

Aleios wrote:Unless the way the variables are handled are compiler specific (or even system specific?), it gives out "main.obj : error LNK2005: "bool quit" (?quit@@3_NA) already defined in booltest.obj" under Visual Studio 2010, yet simply changing the bool in main.cpp to a type of int will cause it to compile.