Elysian Shadows

Ginto8 wrote:#1. Your while loop will simply out put the first and second number infinitely. There is no chance for the user to input a |.

#2. The conditions for your while loop are wrong. It should be this:

Code: Select all

while(number_1 != '|' && number_2 != '|')

if you had number_1 || number_2 != '|', it will continue so long as either number_1 does not equal 0, or number_2 does not equal '|'. Also, you can't have "|". This will create 2 characters; '|' and the character used to terminate strings, '\0'. this will make it so that it is not looked at the way you want it to.

#3. Try to correctly use the [ code ] brackets =P

{
	using namespace std;
	int number_1;
	int number_2;
	cout<<"put in your first number.\n";
	cin>>number_1;
	cout<<"Now enter your second number.To exit the program enter |\n";
	cin>>number_2;
	while(number_1 =!'|' &&number_2 !='|'){
		cout<<number_1<<"  "<<number_2<<"     \n";
	}

wtetzner wrote:You're trying to store a character '|' in an integer. So cin will fail if the user enters '|'. Also, in your while loop, when you compare an integer and a character, it compares the integer against the ascii value of the character.

cplusplusnoob wrote:

wtetzner wrote:You're trying to store a character '|' in an integer. So cin will fail if the user enters '|'. Also, in your while loop, when you compare an integer and a character, it compares the integer against the ascii value of the character.

you are right ill try to fix it.

programmerinprogress wrote:I don't really have the time to test this theory, but i'm going to explain how you could do it (as I see it mentally)

you could get a string of characters, input your number into the string, the string acts as a buffer.

you then use some bitmasks to reduce each character code to a simple digit (so ASCII 48 ('0') becomes 0, 49 becomes 1 etc ), then you 'multiply up' each digit and then add it to an integer value.

I couldn't tell you which bitmask to use, or how the multiplication algorithm would be written, as i'm a little busy now, but if you could come up with a solution using this principle, I would be very interested to find out if that worked.

PS: i'm not lazy and I will try it out when I have the time .

wearymemory wrote:First of all, you don't even tell the user that they could exit the program by entering | when you first ask for the user's input, yet you still check to see if both numbers contain |.

And secondly, why the hell do you need a while loop for that? It doesn't seem logical to do that, unless of course this was assigned to you and you absolutely have to do it this way.

This may not be exactly what you want, but it offers somewhat of a solution to your problem. The overall structure of your program confused me, so this code was my best attempt at imitating it.

Code: Select all

#include <iostream>
using namespace std;

int main ()
{
    int input;
    string str;

    while(1) {

        cout << "Enter a number (| to quit): ";
        cin >> input;

        if(cin.fail()) {
            cin.clear();
            cin >> str;

            if(str == "|") {
                break;
            }
        } else {
            cout << "You entered: " << input << endl;
        }

    }

    return 0;
}