Elysian Shadows

RyanPridgeon wrote:Try this

Code: Select all

#include <iostream>
#include <fstream>
#include <string>
using namespace std;

//VARIABLES//
string filel;
string filen;

//FUNCTIONS//

int main()
{
cout << "FILE NAME: ";
cin >> filen;
cout << "FILE DATA: \n";
cin >> filel;

ofstream fileo(filen.c_str(), ios::out);
fileo.write(filel.c_str(), filel.size());


fileo.close();

return 0;
}

I know it's not using char*, but as you're using C++, I don't really see a reason to.

Sorry if that's not what you wanted.

Ginto8 wrote:Can't you just use:

Code: Select all

string cow = "Moo";
string moose = "";
ifstream read("moose.txt");
ofstream write("cow.txt");

read >> moose;
write << cow;

much easier and simpler than using binary i/o (read()/write()).

MadPumpkin: since there is the argument that sizeof(char) may change in the future, it may be a good idea to replace filel.size() with (sizeof(char) * filel.size()).

Maevik wrote:I think it's your & after the string variable in the first argument. The buffer should not be an adress, and even if it were I would think the & would have to be in front.

MarauderIIC wrote:

Maevik wrote:I think it's your & after the string variable in the first argument. The buffer should not be an adress, and even if it were I would think the & would have to be in front.

Yes. filei.read(&loader, .......

MadPumpkin wrote: well i put the '&' before "loader" now and i get this
(line 18)
error: no matching function for call to `std::basic_ifstream<char, std::char_traits<char> >::read(std::string*, size_t)'|

ifstream filei(filen.c_str(), ios::in);
char buffer = new char[100];
filei.read(buffer, 100);
loader = buffer;
filei.gcount();

fantastico wrote:

MadPumpkin wrote: well i put the '&' before "loader" now and i get this
(line 18)
error: no matching function for call to `std::basic_ifstream<char, std::char_traits<char> >::read(std::string*, size_t)'|

That's because you are passing the function a pointer to a std::string while it's expecting a pointer to a char, where a buffer begins (char* / array of chars). I'm not too familiar with C++ I/O but I think you should create a char array as buffer and read into that. You can copy the buffer into a string to work with it if you want.
Something like that:

Code: Select all

ifstream filei(filen.c_str(), ios::in);
char buffer = new char[100];
filei.read(buffer, 100);
loader = buffer;
filei.gcount();

This will read up to 100 bytes from the stream into the char buffer and copy it into the loader string. Btw, are you sure you wanted to do filen.size() in line 18 as filen is holding your filename, not the file stream.

Ginto8 wrote:or you could do filei.read((char*)&loader, ... )

fantastico wrote:

MadPumpkin wrote: well i put the '&' before "loader" now and i get this
(line 18)
error: no matching function for call to `std::basic_ifstream<char, std::char_traits<char> >::read(std::string*, size_t)'|

That's because you are passing the function a pointer to a std::string while it's expecting a pointer to a char, where a buffer begins (char* / array of chars). I'm not too familiar with C++ I/O but I think you should create a char array as buffer and read into that. You can copy the buffer into a string to work with it if you want.
Something like that:

Code: Select all

ifstream filei(filen.c_str(), ios::in);
char buffer = new char[100];
filei.read(buffer, 100);
loader = buffer;
filei.gcount();

This will read up to 100 bytes from the stream into the char buffer and copy it into the loader string. Btw, are you sure you wanted to do filen.size() in line 18 as filen is holding your filename, not the file stream.

fantastico wrote:

Ginto8 wrote:or you could do filei.read((char*)&loader, ... )

The compiler would accept it, the OS and the programmer wouldn't like the result though