Elysian Shadows

dani93 wrote:When you call the function

Code: Select all

void Attack(Player e)

the object form main is copied to the object called "e". "e" is destroyed after the execution leaves the scope. So you don't change the correct object. To use the object from main, you can pass a reference (or a pointer) to it.

Code: Select all

void Attack(Player& e)

Do you understand what I mean?

There are some other things in your code that aren't... I mean they are not wrong... but also not nice
For the function "Default" you could use a constructor. The definition of the class and the implementations of the methods should be in seperate files.

Ewan wrote:In your Attack function, it's a copy of the instance of Player that's being passed as an argument, not the actual instance. It's like copying a file and putting it into a different folder then modifying the contents of the new file, when really you want to change the data in the original.

You'll need to do this instead:

Change your Attack function to

Code: Select all

     
void Attack(Player *e)
{
       e->SubHP(exp*power);
       cout << "You attacked " << "another player" << " with " << exp*power << " damage!\n";
       cout << "Enemy hp left: " << e->GetHP() << "!\n";
}

and every time you use Attack you will need to do it like this:

Code: Select all

Zer0XoL.Attack(&Slagor);

http://www.cplusplus.com/doc/tutorial/pointers/

Hope this helped

Ewan

EDIT: Hehe you beat me to it

EDIT 2: Dani93's solution is better lol, use his

Zer0XoL wrote:how does constructors work, or what are they?

Player ()                // same name as class
{

                   IsAlive = true;
                   exp = 1;
                   hp = 100;
                   power = 1;
                   mp = 50;

}

Ewan wrote: You'll need to do this instead:

Change your Attack function to
[...]

Ewan wrote:EDIT: Hehe you beat me to it

Ewan wrote:EDIT 2: Dani93's solution is better lol, use his

dani93 wrote:

Zer0XoL wrote:how does constructors work, or what are they?

A constructor is automatically called when you create an object. It has the same name as the class.
Your constructor could look like that:

Code: Select all

Player ()                // same name as class
{

                   IsAlive = true;
                   exp = 1;
                   hp = 100;
                   power = 1;
                   mp = 50;

}

So you don't need to call "Default" everytime you create an object.

I'm not really a C++ pro. Why should a reference be better than a pointer? OK, you don't need to care about if you use values or adresses

dani93 wrote:

Ewan wrote:EDIT 2: Dani93's solution is better lol, use his

I'm not really a C++ pro. Why should a reference be better than a pointer? OK, you don't need to care about if you use values or adresses

Zer0XoL wrote:Ooh, that is really usefull feature!
I can´t thank you more

Ewan wrote:Well, mainly because with pointers you have to use -> to access member functions, and when passing the argument you have to put &Slagor or whatever instead of just Slagor. Not that references are always better, but this time they just made more sense.

Ewan wrote:Btw, when I said "do this instead" I was saying instead of his original code - I hadn't seen your reply.

MarauderIIC wrote:You can reseat a pointer, ie, make it point to something else. You can also delete what it points to. If you shouldn't be able to delete what the pointer points to, you should use a reference.

Zer0XoL wrote: void SubHP(int p)
{
hp = hp - p;
}

newbie1234 wrote: And offcourse, you could use hp -= p;