Elysian Shadows

Lucas wrote:In the bullet::createbullets() function could you not just get the x, y of the player as you normally would?

For example, since you must have created an instance of the player somewhere, for the bullets x, y could you not just say something like:

Code: Select all

x = PlayerInstance.get_x();
y = PlayerInstance.get_y();

or now that I'm thinking about it a little more instead of hard coding the players instance into the class function like that you could just pass the function a pointer to your player instance.
That way you wouldn't be limited to only creating bullets at the player.

Code: Select all

void bullets::createbullets(player *PlayerInstance)
{
   x = PlayerInstance->get_x();
   y = PlayerInstance->get_y();
}

I hope that made sense, and I hope my code is ok, my thoughts are in the right place I'm just having trouble putting them into words :P

GyroVorbis wrote:Dudes...

Code: Select all

void bullets::createbullets(Player &player)
{
   SDL_Rect pTemp = player.getprect();

   bulletRect.x = pTemp.x;
   bulletRect.y = (pTemp.y - 10);

   bDead = 1;
   bVel = 1;
}

That will do what you want it to do, provided that

Code: Select all

Player::getprect()

is a public function.

edit: I will elaborate. When you call bullets::createbullets() now, you should be passing the player object to it, like so:

Code: Select all

bullsets.createbullets(player)

Since your createbullets function receives the Player class with '&', it is a reference. Now you can refer to player as you normally would within this function and call its member.

class Player
{
private:
	SDL_Rect p;
	int pVel;

public:
	Player();
	SDL_Rect getprect();
	void input();
	void move();
	void draw();
};


class Bullets
{
private:
	SDL_Rect bulletRect;
	int bVel;
	int bDead;  //has the bullet collided with an object or left the screen. 0 = dead

public:
	Bullets();
	void createbullets();
	void updatebullets();
	void checkbullets();
	void killbullets();
};


SDL_Rect Player::getprect()
{
	return p;
}


void Bullets::createbullets(Player &player)
{
	SDL_Rect pTemp = player.getprect();

	bulletRect.x = pTemp.x;
	bulletRect.y = (pTemp.y - 10);

	bDead = 1;
	bVel = 1;
}

Bakkon wrote:

Code: Select all

public:
   Bullets();
   void createbullets(Player &player);
   void updatebullets();
   void checkbullets();
   void killbullets();

You need that parameter in your prototype.

class bullets
{
private:
	SDL_Rect bulletRect;
	int bVel;
	int bDead;  //has the bullet collided with an object or left the screen. 0 = dead

public:
	bullets();
	void createbullets(player &playerRef);
	void updatebullets();
	void checkbullets();
	void killbullets();
};


void bullets::createbullets(player &playerRef)
{
	SDL_Rect pTemp = playerRef.getprect();

	bulletRect.x = pTemp.x;
	bulletRect.y = (pTemp.y - 10);

	bDead = 1;
	bVel = 1;
}

teamtwentythree wrote:Its been a while since I've done C++, but are your class names matching in case? It seems like you went from camel case to all lowercase.

Player != player in C++

Bakkon wrote:As t23 said, make sure the Player class is capatilized. Also, if you have seperate source files, make sure you're including player.h in the bullet header file.

Should I be seperating each class into their own header/cpp files?

Innerscope wrote:Why are we passing a player object to a bullet? That doesn't seem right to me...

hurstshifter wrote: I'll try separating the classes into different source files. Not sure if this is my problem but hey, anything is worth a shot.

Innerscope wrote: Why are we passing a player object to a bullet? That doesn't seem right to me...