The Next Generation of 2D Roleplaying Games
http://elysianshadows.com/phpBB3/
Code: Select all
std::vector< std::vector< xyz > > myDynamic2dArray;
Unless you NEED it to be dynamic, you don't want to use vectors. And even if you need it to be dynamic, you only want to use vectors if they have a significant advantage over simple dynamic arrays.K-Bal wrote:Without code there is not much to say. You could use std::vector though:
Code: Select all
std::vector< std::vector< xyz > > myDynamic2dArray;
There are many ways to do it. I like it for it's simplicity and would never use it in high performance programs.Ginto8 wrote: Unless you NEED it to be dynamic, you don't want to use vectors. And even if you need it to be dynamic, you only want to use vectors if they have a significant advantage over simple dynamic arrays.
Code: Select all
//Image.cpp
#include "Image.h"
Image::Image(int H, int W)
{
Height = H;
Width = W;
**Points = *new Location[Height]; //This is the problem
for(int c = 0; c < H; c ++)
{
*Points[c] = *new Location[Width];
}
for(int h = 0; h < H; h ++)
{
for(int w = 0; w < W; w ++)
{
Points[h][w].setLocation(*new Location((float)w / 3 , (float)h / 3, 0));
}
}
}
Image::~Image()
{
//dtor
}
float Image::getX(int H, int W)
{
return Points[H][W].getX();
}
float Image::getY(int H, int W)
{
return Points[H][W].getY();
}
float Image::getZ(int H, int W)
{
return Points[H][W].getZ();
}
int Image::getHeight()
{
return Height;
}
int Image::getWidth()
{
return Width;
}
Code: Select all
//Image.h
#include "Location.h"
class Image
{
public:
Image(int H, int W);
virtual ~Image();
float getX(int H, int W);
float getY(int H, int W);
float getZ(int H, int W);
int getHeight();
int getWidth();
protected:
private:
Location **Points;
int Height;
int Width;
};
THAT is a very bad idea. I'm pretty sure this is memory leak city, unless you are explicitly freeing the new locations when they're done being used. I'm fairly certain that you just want to instantiate the temporary variable on the stack.davidthefat wrote:Code: Select all
Points[h][w].setLocation(*new Location((float)w / 3 , (float)h / 3, 0));
No shit, it's a problem. The syntax is entirely wrong.davidthefat wrote:Code: Select all
**Points = *new Location[Height]; //This is the problem
Code: Select all
Location*** Points = new Location**[COLS];
for(int i = 0; i < COLS; i++)
Points[i] = new Location*[ROWS];
for(int y = 0; y < COLS; y++)
for(int x = 0; x < ROWS; x++)
Points[x][y] = new Location(params);
for(int y = 0; y < COLS; y++)
for(int x = 0; x < ROWS; x++)
delete Points[x][y];
for(int i = 0; i < COLS; i++)
delete [] Points[i];
delete [] Points;
You wanted to say heapGyroVorbis wrote: ALWAYS beware of instantiating temporary variables on the stack--unless whatever is receiving them is also deleting them, you are losing your reference to the pointer and can never free it.
Ah, shit. You're right.K-Bal wrote:You wanted to say heapGyroVorbis wrote: ALWAYS beware of instantiating temporary variables on the stack--unless whatever is receiving them is also deleting them, you are losing your reference to the pointer and can never free it.
Bakkon wrote:No shit, it's a problem. The syntax is entirely wrong.davidthefat wrote:Code: Select all
**Points = *new Location[Height]; //This is the problem
Code: Select all
Location*** Points = new Location**[COLS]; for(int i = 0; i < COLS; i++) Points[i] = new Location*[ROWS]; for(int y = 0; y < COLS; y++) for(int x = 0; x < ROWS; x++) Points[x][y] = new Location(params); for(int y = 0; y < COLS; y++) for(int x = 0; x < ROWS; x++) delete Points[x][y]; for(int i = 0; i < COLS; i++) delete [] Points[i]; delete [] Points;
Unfortunately, that has the same error... 
IDK what to do... Its due on Wednesday and I still have to get the socket connection working too...